Skip to content

Fix a grammar mistake in serialization.md and don't imply _ is valid in dns hostnames #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix a grammar mistake in serialization.md and don't imply _ is valid in dns hostnames #161

wants to merge 1 commit into from

Conversation

@jbouzane
Copy link

@jbouzane jbouzane commented Jun 20, 2016

  • Fix a grammar error ("follow comply" -> "comply")
  • Underscores are invalid in hostnames in DNS; fix the text not to imply they are valid.

@vbatts
Copy link
Member

vbatts commented Jun 20, 2016 •
edited by caniszczyk
Loading

LGTM, but lacking DCO signature, and tests fail

Approved with PullApprove

@wking
Copy link
Contributor

wking commented Jun 20, 2016

On Mon, Jun 20, 2016 at 04:26:01PM -0700, Vincent Batts wrote:

LGTM, but lacking DCO signature, and tests fail

Test failures look unrelated (e.g. 1).

@wking
Copy link
Contributor

wking commented Jun 20, 2016

On Mon, Jun 20, 2016 at 04:30:02PM -0700, W. Trevor King wrote:

Test failures look unrelated (e.g. 1).

Maybe related to #160? I don't see any other recent activity that
sounds like a cause of:

open /manifest-list-schema.json: no such file or directory

@runcom
Copy link
Member

runcom commented Jun 21, 2016 •
edited
Loading

doesn't seem related (on my laptop)

$ make test 
go test -race ./...
?       github.com/opencontainers/image-spec/cmd/oci-image-tool [no test files]
?       github.com/opencontainers/image-spec/image  [no test files]
ok      github.com/opencontainers/image-spec/schema 1.151s

@runcom
Copy link
Member

runcom commented Jun 21, 2016

well, unless CI is running the old esc version maybe (?)

@wking
Copy link
Contributor

wking commented Jun 21, 2016

On Mon, Jun 20, 2016 at 05:00:45PM -0700, Antonio Murdaca wrote:

doesn't seem related

Travis history for master broke at build 337 [1,2], which was after #158
was merged. And it's failing with that same “no such file” error.

@wking wking mentioned this pull request Jun 21, 2016
Closed
@jbouzane jbouzane closed this Jun 21, 2016
@wking
Copy link
Contributor

wking commented Jun 21, 2016

On Tue, Jun 21, 2016 at 02:04:39AM -0700, Jason Bouzane wrote:

Closed #161.

Moved to #163, with f3797e1 → e38f194 adding a Signed-off-by and a
more detailed commit message to the same change.

@philips philips mentioned this pull request Sep 21, 2016
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jbouzane @vbatts @wking @runcom